-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of config hints; some restructure; donation link #69
Conversation
deleted inlined <styles> - only 2px changes added a comment what the navbar code will do and added if loop for setup pages directly into navbar code
we have placeholders no need anymore
|
||
error_page 405 = @nocache; | ||
|
||
try_files /wp-content/cache/cachify/https-${host}${uri}index.html /wp-content/cache/cachify/${host}${uri}index.html @nocache; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wp_make_link_relative( content_url( $path ) ) needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried this? Currently without testing I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean try files? I didnt test this. I have no nginx server. But this code was posted by swispydy on GitHub in an issue (sry I'm on a mobile device). And the user posted this code on his website so the code should work.
My thought behind all this is we should include standard configs that work for every server with less notes so a standard user is not confused. If someone wants specific code for HTTP or HTTPS only he can look into the wiki. But if we try to include 3 different configs it will confuse all users that are new with such things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean have try with your idea to use content_url( $path )
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh OK
True - wp_make_link_relative( content_url( $path ) ), should be the right one
Do we need this code phrase here to print the right path - for these both code lines?
} | ||
|
||
## PROTECT CACHE | ||
location ~ /wp-content/cache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wp_make_link_relative( content_url( $path ) ) needed?
Should great and helpful, but we need a test about different installs. |
what i changed:
to do list:
#27 #32 #39 #68